On 13/03/2025 08:11, Krzysztof Kozlowski wrote: > On 12/03/2025 20:59, Jameson Thies wrote: >> Check for cros_ec_ucsi to be defined in the OF device tree or an ACPI >> node. If it is defined by either OF or ACPI, it does not need to be >> added as a subdevice of cros_ec_dev. > > No, it does not have to. You just populate the children and appropriate Uh, I did not notice that it is !of_find_compatible_node(), so this comment should be rephrased - you just add MFD children anyway and if there is no node, they won't be created. > devices will be created automatically. None of parent devices should > ever check if the child exist to create a child - it makes no sense. This is still valid - none of parents should be poking around to see if there is a child or not. The core handles it, DT handles it etc. Best regards, Krzysztof
