On Tue, Mar 11, 2025 at 12:42:08PM +0100, Vinod Koul wrote: > On 11-03-25, 12:40, Vinod Koul wrote: > > On 09-03-25, 14:29, Christian Marangi wrote: > > > Add support for Airoha AN7581 USB PHY driver. AN7581 supports up to 2 > > > USB port with USB 2.0 mode always supported and USB 3.0 mode available > > > only if the Serdes port is correctly configured for USB 3.0. > > > > > > On xLate probe, the Serdes mode is validated and the driver return error > > > if the Serdes mode doesn't reflect the expected mode. This is required > > > as Serdes mode are controlled by the SCU SSR bits and can be either USB > > > 3.0 mode or HSGMII or PCIe 2. In such case USB 3.0 won't work. > > > > > > If the USB 3.0 mode is not supported, the modes needs to be also > > > disabled in the xHCI node or the driver will report unsable clock and > > > fail probe. > > Also I dont see phy depends on rest. Please split this and post phy bits > separately at least.. Well USB doesn't work without this driver so they are indirectly dependent. Will split and address all the other comments. > > -- > ~Vinod -- Ansuel
