> > The log shows no call to usb_serial_generic_write_room() > > Do you consider this a bug in the tty layer? > > Actually this all makes sense because of where it was hanging. A reply of > 0 to the tty->ops->write will cause it to either return (O_NONBLOCK) or > sleep in the n_tty write code waiting for a write_wait wakeup > (tty_wakeup(tty)) > > So the fix does indeed look correct. Is it really a fix? If the fifo is already full the write urb should be in use and Oliver's patch would amount to only a minor optimisation as usb_serial_generic_write_start would return 0 anyway. /Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
