On Tue, Feb 04, 2025 at 04:29:08PM +0530, Prashanth K wrote: > Currently the USB gadget will be set as bus-powered based solely > on whether its bMaxPower is greater than 100mA, but this may miss > devices that may legitimately draw less than 100mA but still want > to report as bus-powered. Similarly during suspend & resume, USB > gadget is incorrectly marked as bus/self powered without checking > the bmAttributes field. Fix these by configuring the USB gadget > as self or bus powered based on bmAttributes, and explicitly set > it as bus-powered if it draws more than 100mA. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 5e5caf4fa8d3 ("usb: gadget: composite: Inform controller driver of self-powered") > Signed-off-by: Prashanth K <prashanth.k@xxxxxxxxxxxxxxxx> > --- > drivers/usb/gadget/composite.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) What type of "comments" are you wanting here? For obvious reasons, I can't apply patches tagged "RFC" but I don't see what you are wanting us to do here. confused, greg k-h