On Thu, Feb 13, 2025 at 5:47 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Feb 12, 2025 at 11:16:35PM -0800, Badhri Jagan Sridharan wrote: > > On Tue, Feb 11, 2025 at 5:50 AM Jos Wang <joswang1221@xxxxxxxxx> wrote: > > > > > > On Tue, Feb 11, 2025 at 7:51 AM Badhri Jagan Sridharan > > > <badhri@xxxxxxxxxx> wrote: > > > > > > > > On Mon, Feb 10, 2025 at 3:02 PM Amit Sunil Dhamne <amitsd@xxxxxxxxxx> wrote: > > > > > > > > > > > > > > > On 2/8/25 11:17 PM, joswang wrote: > > > > > > From: Jos Wang <joswang@xxxxxxxxxx> > > > > nit: From https://elixir.bootlin.com/linux/v6.13.1/source/Documentation/process/submitting-patches.rst#L619 > > > > > > > > - A ``from`` line specifying the patch author, followed by an empty > > > > line (only needed if the person sending the patch is not the author). > > > > > > > > Given that you are the author, wondering why do you have an explicit "From:" ? > > > > > > > Hello, thank you for your help in reviewing the code. > > > My company email address is joswang@xxxxxxxxxx, and my personal gmail > > > email address is joswang1221@xxxxxxxxx, which is used to send patches. > > > Do you suggest deleting the "From:" line? > > > I am considering deleting the "From:" line, whether the author and > > > Signed-off-by in the patch need to be changed to > > > "joswang1221@xxxxxxxxx". > > > > Yes, changing signed-off to joswang1221@xxxxxxxxx will remove the need > > for "From:". > > Go ahead with it if it makes sense on your side. > > No, what was done here originally is correct, please do not ask people > to not actually follow the correct procedure. > > Jos, thank you, there is nothing wrong with the way you sent this. > > thanks, > > greg k-h Thanks，I will submit the v2 version patch soon. Thanks, Jos
