On Fri, Jan 24, 2025 at 10:28:00AM +0000, Chester A. Unal via B4 Relay wrote: > From: "Chester A. Unal" <chester.a.unal@xxxxxxxxxx> > > MeiG Smart SLM828 is an LTE-A CAT6 modem with the mPCIe form factor. The > "Cls=ff(vend.) Sub=10 Prot=02" and "Cls=ff(vend.) Sub=10 Prot=03" > interfaces respond to AT commands. Add these interfaces. > > The product ID the modem uses is shared across multiple modems. Therefore, > add comments to describe which interface is used for which modem. > > T: Bus=01 Lev=01 Prnt=05 Port=01 Cnt=01 Dev#= 6 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=2dee ProdID=4d22 Rev=05.04 > S: Manufacturer=MEIG > S: Product=LTE-A Module > S: SerialNumber=4da7ec42 > C: #Ifs= 6 Cfg#= 1 Atr=80 MxPwr=500mA > I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=10 Prot=01 Driver=(none) > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I: If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=10 Prot=02 Driver=(none) > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > I: If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=10 Prot=03 Driver=(none) > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=85(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > I: If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=10 Prot=04 Driver=(none) > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=87(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > I: If#= 4 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > E: Ad=88(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I: If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=10 Prot=05 Driver=qmi_wwan > E: Ad=0f(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=89(I) Atr=03(Int.) MxPS= 8 Ivl=32ms > E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > Signed-off-by: Chester A. Unal <chester.a.unal@xxxxxxxxxx> > Changes in v2: > - Add to the relevant comment that SLM828 is based on Qualcomm SDX12. > - Add to the comment for certain interface specification that SRM815 > uses that interface specificiation as well. > - Link to v1: https://lore.kernel.org/r/20250123-for-johan-meig-slm828-v1-1-6456996e94a5@xxxxxxxxxx > /* MeiG Smart Technology products */ > #define MEIGSMART_VENDOR_ID 0x2dee > -/* MeiG Smart SRM815/SRM825L based on Qualcomm 315 */ > +/* MeiG Smart SLM828, SRM815, and SRM825L use the same product ID. SLM828 is > + * based on Qualcomm SDX12. SRM815 and SRM825L are based on Qualcomm 315. > + */ Thanks for the patch and for documenting how these entries are related (here and below). I fixed up the multi-line comment above to follow the usual style: /* * ... */ when applying. Johan
