On Mon, Feb 10, 2025 at 09:42:46AM -0600, Matt Lee wrote: > The submitted patch fixes a crash we are experiencing on every shutdown. > Perhaps the better solution is to remove the spin_lock_irqsave/restore? Please don't top post. Having a lock/unlock pair without anything in it can be used for something (it's a gate primitive), but I don't think that it's being used for that here. > I tested removing the spin_lock completely and the crash issue was eliminated. > Happy to update the patch if this is the preferred method. Ideally fix the root issue in that this lock is needed to protect the data here, so removing it doesn't actually fix the real problem, only trade the crash for a race condition, right? thanks, greg k-h
