RE: [PATCH 1/1] atmel uaba : Adding invert vbus_pin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Mon, Jan 04, 2010 at 02:01:59PM +0100, Eirik Aanonsen wrote:
> > Adding vbus_pin_inverted so that the usb detect pin can be active
> high or low.
> > This because depending on HW implementation it is better to have
> active low.
> > Also replaced the pio_get_value(udc->vbus_pin); with a call to
> vbus_is_present(udc);
> >
> > Signed-off-by: Eirik Aanonsen <eaa@xxxxxxxxxxxxxx>
> 
> Please always run your patches through 'scripts/checkpatch.pl' before
> sending them so that you don't accidentally add coding style errors.
> 
> thanks,
> 
> greg k-h

Yes I'm sorry I got that feedback from several others as well.

That is why I resubmitted the patch on 05.Jan. But under the same name, and since then I have not received any feedback on that patch.

***
Snip from local:

./scripts/checkpatch.pl 0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch 
total: 0 errors, 0 warnings, 38 lines checked

0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch has no obvious style problems and is ready for submission.
***

Best regards
____________________________________________________
 
Eirik Aanonsen
SW Developer
E-mail: eaa@xxxxxxxxxxxxxx 
Phone: +47 90 68 11 92
Fax: +47 37 03 56 77
____________________________________________________



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux