Re: [PATCH 1/2] USB: max3421: Improve retransmit handling for NAK responses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 10, 2025 at 07:48:28AM -0600, Matt Lee wrote:
> This reverts a previously submitted patch where the slow retransmit was
> removed.
> 
> The max3421 driver would immediately retry transmissions indefinitely upon
> receiving a NAK response, leading to potential stalls.
> 
> This patch re-introduces a limit (`NAK_MAX_FAST_RETRANSMITS`) on how many
> times a request is retransmitted immediately.  After reaching this limit,
> the driver falls back to a slower retransmit strategy using
> `max3421_slow_retransmit()`.
> 
> This improves robustness when dealing with unresponsive USB devices.
> 
> Signed-off-by: Matt Lee <matt@xxxxxxxxxx>
> ---
>  drivers/usb/host/max3421-hcd.c | 7 +++++++
>  1 file changed, 7 insertions(+)

I got 2 copies of this, is that intentional?

And patch 2/2 should be threaded with this one, did you use git
send-email to send these out?

thanks,

greg k-h




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux