On Sun, Feb 09, 2025 at 07:10:47PM +0100, Marek Vasut wrote:
> On 2/9/25 4:44 PM, Greg Kroah-Hartman wrote:
> > On Sun, Feb 09, 2025 at 03:56:11PM +0100, Marek Vasut wrote:
> > > Add Renesas R-Car D3 USB Download mode quirk and update comments
> > > on all the other Renesas R-Car USB Download mode quirks to discern
> > > them from each other. This follows R-Car Series, 3rd Generation
> > > reference manual Rev.2.00 chapter 19.2.8 USB download mode .
> > >
> > > Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode")
> > > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> > > ---
> > > Cc: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> > > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Oliver Neukum <oneukum@xxxxxxxx>
> > > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> > > Cc: linux-usb@xxxxxxxxxxxxxxx
> > > Cc: stable@xxxxxxxxxxxxxxx
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> [...]
>
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> >
> > - You have marked a patch with a "Fixes:" tag for a commit that is in an
> > older released kernel, yet you do not have a cc: stable line in the
> > signed-off-by area at all, which means that the patch will not be
> > applied to any older kernel releases. To properly fix this, please
> > follow the documented rules in the
> > Documentation/process/stable-kernel-rules.rst file for how to resolve
> > this.
>
> Cc: stable is right there, below --- so it wouldn't become part of the
> commit message when the patch is applied. Is that OK too ?
No that is not, it needs to become part of the commit message, as per
the kernel documentation.
thanks,
greg k-h
