On Thu, Feb 06, 2025 at 03:07:59PM -0500, Lyude Paul wrote: > On Thu, 2025-02-06 at 19:08 +0100, Thomas Weißschuh wrote: > > > + > > > + device_initialize(dev); > > > + dev->release = faux_device_release; > > > + dev->parent = &faux_bus_root; > > > > I guess nobody will want to hang these off a different parent. > > Oh - this is a good point that slipped my mind, how would we want to handle > this case? The reason I ask is since we have things like > drivers/gpu/drm/display/drm_dp_aux_dev.c which currently use the virtual > device API but iirc do actually assign the DRM device owning the aux device as > the parent. Having a parent is fine, I just hadn't found any users of that yet. I'll go add that option for v4. thanks, greg k-h