Hi Greg,
Just a check here:
> > + dev_err(&mctp_usb->usbdev->dev, "%s: urb status: %d\n",
> > + __func__, status);
>
> This could flood the logs, are you sure you need it at dev_err()
> level?
>
> And __func__ is redundant, it's present in dev_*() calls already.
am I missing something then?
[ 146.130170] usb 2-1: short packet (hdr) 6
emitted from:
dev_dbg(&mctp_usb->usbdev->dev,
"short packet (hdr) %d\n",
hdr->len);
Seems like we get the driver name, but not the function.
I'm happy to remove the __func__ output either way, but I will also
make the logs a little more descriptive for context, if we don't have
func data.
Cheers,
Jeremy
