On Thu, Feb 06, 2025 at 03:11:25PM +0800, Jeremy Kerr wrote: > Hi Greg, > > Thanks for the review. > > > > --- /dev/null > > > +++ b/include/linux/usb/mctp-usb.h > > > @@ -0,0 +1,28 @@ > > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > > +/* > > > + * mctp-usb.h - MCTP USB transport binding: common definitions. > > > + * > > > + * These are protocol-level definitions, that may be shared between host > > > + * and gadget drivers. > > > > Perhaps add a link to the spec? > > Can do. I have one in the actual driver, but can replicate that here if > it's helpful. Isn't this a usb.org spec and not a vendor-specific one? > > > + * Copyright (C) 2024 Code Construct Pty Ltd > > > > It's 2025 now :) > > WHAT?! > > :D > > (this was started in 2024, and I have some preliminary versions up since > then, but I assume the last date is preferrable) As per copyright norms, list the real dates, so that would be: Copyright (C) 2024-2025 ... thanks, greg k-h
