On Mon, Feb 03, 2025 at 05:11:03PM +0200, Andy Shevchenko wrote: > On Mon, Feb 03, 2025 at 03:25:17PM +0100, Greg Kroah-Hartman wrote: ... > I don't remember by heart what it does include, I would go with IWYU principle > and list above all what we use. > > container_of.h > device.h > export.h > printk.h > types.h Probably types.h is too much and stddef.h would suffice (as it provides NULL pointer definition). -- With Best Regards, Andy Shevchenko