Andy Isaacson wrote: > For example, look at 5d66fe92. The semantic patch is blissfully, > incredibly clear. It makes the sun shine down through the clouds, the > birds sing, and the kzalloc align. It's 10 lines long and is quite > intuitive and explanatory. In that case, I think it's clear that the > spatch is worth the changelog space it takes up, even though the > changelog is larger than the diff by quite a margin. 5d66fe92 is another example of what I was talking about. The changelog could have read: drivers/net : Correct the size argument to kzalloc lp->rx_skb is for an array of pointers, not of structs. Found using coccinelle. Signed-off-by: ... Tell me again in what way the script is of any importance or of any help in the permanent SCM changelog after commit. I agree with you that it is very good to have the script in the patch posting, but I disagree about the changelog. -- Stefan Richter -=====-==-=- ---= -==== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
