Re: [PATCH] net: usb: qmi_wwan: Add error handling for usbnet_get_ethernet_addr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 20.01.25 18:00, Wentao Liang wrote:
In qmi_wwan_bind(), usbnet_get_ethernet_addr() is called
without error handling, risking unnoticed failures and
inconsistent behavior compared to other parts of the code.

Hi,

unfortunately this makes no difference between a genuine
IO error and the device simply providing no string.
Does the device need to provide a string for the MAC
in order to function?

Frankly, this patch does not look like a good idea,
as it disregards the reasoning expressed in the comment
seen in the code.

	Regards
		Oliver





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux