On Tue, Dec 31, 2024 at 9:47 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Sun, Dec 22, 2024 at 06:52:38PM +0800, joswang wrote: > > From: Jos Wang <joswang@xxxxxxxxxx> > > > > Add "pd2-sender-response-time-ms" and "pd3-sender-response-time-ms" > > DT attributes to better solve the following test items in the usb > > pd compliance test: > > TEST.PD.PROT.SRC3.2 SenderResponseTimer Timeout > > TEST.PD.PROT.SNK.6 SenderResponseTimer Timeout > > > > This is to enable setting of platform/board specific timer values as > > these timers have a range of acceptable values. > > > > [1] https://usb.org/document-library/ > > usb-power-delivery-compliance-test-specification-0/USB_PD3_CTS_Q4_2024_OR.zip > > Don't wrap this line. > OK > > > > Signed-off-by: Jos Wang <joswang@xxxxxxxxxx> > > --- > > v1 -> v2: > > - modify the commit message > > - patch 1/2 and patch 2/2 are placed in the same thread > > > > .../bindings/connector/usb-connector.yaml | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > index 67700440e23b..83be66f6d406 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml > > @@ -293,6 +293,26 @@ properties: > > PD negotiation till BC1.2 detection completes. > > default: 0 > > > > + pd2-sender-response-time-ms: > > + description: Represents the PD20 max time in ms that port started from > > + the time the last bit of the GoodCRC Message EOP has been received by > > + the Physical Layer, it shall be stopped when the last bit of the expected > > + response Message EOP has been received by the Physical Layer. A timeout > > + leads to a hard reset message by the port. > > I can only guess that 'pd2' and 'PD20' refer to Power Delivery 2.0. > Yes, 'pd2' and 'PD20' refer to Power Delivery 2.0. > > + minimum: 24 > > + maximum: 30 > > + default: 27 > > + > > + pd3-sender-response-time-ms: > > + description: Represents the PD30 max time in ms that port started from > > + the time the last bit of the GoodCRC Message EOP has been received by > > + the Physical Layer, it shall be stopped when the last bit of the expected > > + response Message EOP has been received by the Physical Layer. A timeout > > + leads to a hard reset message by the port. > > And pd3? > Is your suggestion to change the description of PD20 and PD30 to Power Delivery 2.0 and 3.0? > > + minimum: 27 > > + maximum: 33 > > + default: 30 > > + > > dependencies: > > sink-vdos-v1: [ sink-vdos ] > > sink-vdos: [ sink-vdos-v1 ] > > -- > > 2.17.1 > >
