On 27.12.2024 6:13 PM, Pengyu Luo wrote:
> The Embedded Controller in the Huawei Matebook E Go (s8280xp)
> is accessible on &i2c15 and provides battery and adapter status,
> port orientation status, as well as HPD event notifications for
> two USB Type-C port, etc.
>
> Add the EC to the device tree and describe the relationship among
> the type-c ports, orientation switches and the QMP combo PHY.
>
> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>
> ---
> .../boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 139 ++++++++++++++++++
> 1 file changed, 139 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts b/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts
> index 09b95f89e..09ca9a560 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts
> @@ -28,6 +28,7 @@ / {
>
> aliases {
> i2c4 = &i2c4;
> + i2c15 = &i2c15;
> serial1 = &uart2;
> };
>
> @@ -216,6 +217,40 @@ map1 {
> };
> };
>
> + usb0-sbu-mux {
> + compatible = "pericom,pi3usb102", "gpio-sbu-mux";
> +
> + select-gpios = <&tlmm 164 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb0_sbu_default>;
Please preserve this order:
property-n
property-names
> +
> + orientation-switch;
This
> +
> + port {
> + usb0_sbu_mux: endpoint {
> + remote-endpoint = <&ucsi0_sbu>;
And this section have incorrect whitespacing (one tab too many, make
sure you set your tab width to 8 spaces)
Same for usb1-sbu-mux
[...]
> + i2c15_default: i2c15-default-state {
> + pins = "gpio36", "gpio37";
> + function = "qup15";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> mode_pin_active: mode-pin-state {
> pins = "gpio26";
> function = "gpio";
> @@ -1301,6 +1426,20 @@ tx-pins {
> };
> };
>
> + usb0_sbu_default: usb0-sbu-state {
> + pins = "gpio164";
> + function = "gpio";
> + bias-disable;
> + drive-strength = <16>;
> + };
> +
> + usb1_sbu_default: usb1-sbu-state {
> + pins = "gpio47";
> + function = "gpio";
> + bias-disable;
> + drive-strength = <16>;
> + };
Similarly, please keep drive-strength above bias for consistency
lgtm otherwise
Konrad
