On 29/12/2024 10:04, Pengyu Luo wrote: >>>>> + >>>>> +struct gaokun_ec; >>>>> +struct notifier_block; >>>> >>>> Drop, include proper header instead. >>>> >>> >>> I agree, I copy 'struct notifier_block;' from >>> include/linux/platform_data/lenovo-yoga-c630.h >> >> Please don't pollute header files with extra dependencies. It's usually >> better to just forware-declare the struct instead of adding unnecessary >> include. >> > > Both of you are resonable. So how? > > BTW, Krzysztof said I would recommend differently, but I am fine with other approach if other reviewers have their preference. > >>> You need kerneldoc, in the C file, for all exported functions. > > So Dmitry is here, I want to check again, should I add kerneldoc for all > exported functions? C630 one never added all kerneldocs. In my driver, > some function names have already indicated many things, some complex > functions have been doced. Best regards, Krzysztof
