[no subject]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



So can I use?
- enum:
	- huawei,gaokun-gen2
	- huawei,gaokun-gen3

Some backgroud:
There are 3 variants, Huawei released first 2 at the same time.
Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2.
Huawei Matebook E Go(sc8280xp@3.0GHz), codename is gaokun3.
Huawei Matebook E Go 2023(sc8280xp@2.69GHz).

> > +
> > +  reg:
> > +    const: 0x38
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  connector:
> > +    $ref: /schemas/connector/usb-connector.yaml#
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c15 {
>
> i2c
>

Agree

> > +        clock-frequency = <400000>;
> > +
> > +        pinctrl-names = "default";
> > +        pinctrl-0 = <&i2c15_default>;
>
> Drop all three above and test your bindings. This cannot work and test
> will tell you what is missing.
>

Agree

> > +
> > +        embedded-controller@38 {
> > +            compatible = "huawei,sc8280xp-gaokun-ec", ""huawei,gaokun-ec";
> > +            reg = <0x38>;
> > +
> > +            interrupts-extended = <&tlmm 107 IRQ_TYPE_LEVEL_LOW>;
> > +
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            connector@0 {
>
> Test your bindings - you do not have node connector@0.
>

I have rewritten it locally. So I will add the following and do some fixes
in v2.

patternProperties:
  '^connector@[01]$':
    $ref: /schemas/connector/usb-connector.yaml#

    properties:
      reg:
        maxItems: 1

>
>
> Best regards,
> Krzysztof

Thanks,
Pengyu

[1] https://consumer.huawei.com/en/support/content/en-us15945089
[2] https://github.com/matebook-e-go/uup-drivers-sc8280xp/releases




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux