On Fri, Dec 27, 2024 at 01:51:51PM +0800, Pei Xiao wrote: > sparse warnings: > drivers/usb/typec/ucsi/ucsi_yoga_c630.c:101:30: sparse: sparse: > symbol 'yoga_c630_ucsi_ops' was not declared. Should it be static? > That's a nice warning message, but doesn't explain what this change is actually doing. Please read the kernel documentation for how to properly write a changelog commit for what needs to go here. thanks, greg k-h