On Wed, Dec 18, 2024 at 01:45:47PM +0800, Xu Yang wrote: > > > Fixes: 77e85107a771 ("usb: typec: tcpci: support edge irq") > > > Cc: stable@xxxxxxxxxxxxxxx > > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx> > > > > > > > This commit message was not super clear to me. It didn't mention that > > it's tcpci->regmap which is the NULL pointer. (Obviously there are a > > lot of other NULL pointers, but that's the one which will crash). > > Ahh, actually tcpci itself is the NULL pointer and kernel will crash when > get regmap. Because if tcpci is a valid pointer, all of its members will > be valid too. Anyway, I will add such info to commit message. Thanks! regards, dan carpenter