On Sun, Dec 15, 2024 at 12:41:03PM +0100, Karol P wrote: > On Thu, 7 Nov 2024 at 06:15, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Wed, Nov 06, 2024 at 07:30:32PM +0100, Karol Przybylski wrote: > > > In case of faulty copy_from_user call inside ffs_epfile_ioctl, error code is > > > saved in a variable. However, this variable is later overwritten in every possible > > > path, which overshadows initial assignment. > > > > > > This patch fixes it by returning the error code immediately and exiting the function. > > > > > > Error discovered in coverity scan - CID 1583682 > > > > > > Signed-off-by: Karol Przybylski <karprzy7@xxxxxxxxx> > > > --- > > > drivers/usb/gadget/function/f_fs.c | 9 +++------ > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > What commit id does this fix? > > 7b07a2a7ca02a, usb: gadget: functionfs: Add DMABUF import interface Then why not use the Fixes: tag? > > How was this change tested? > > I compiled the kernel and ran it on my machine. Did you exercise this codepath? > Are there other ways to reliably test such change? Exercise the codepath by using the module and passing in a value to test your change. thanks, greg k-h
