Re: [PATCH] usb:Don't use GFP_KERNEL while we cannot reset a storage device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, 12. Januar 2010 21:09:13 schrieb Alan Stern:
> On Tue, 12 Jan 2010, Oliver Neukum wrote:
> 
> > Am Dienstag, 12. Januar 2010 16:14:00 schrieb Alan Stern:
> > > This last two changes seem unnecessary.  If you're in 
> > > usb_set_configuration() then usb_storage (or anything else) either 
> > > isn't bound or is about to be unbound from the device's interfaces.  
> > > Hence you don't have to be concerned about error recovery.
> > 
> > Hm, strictly speaking yes. But as the driver is technically still
> > bound, we'd take an unnecessary timeout.
> 
> Sure -- a one-second timeout that happens whenever memory pressure 
> forces usb_set_configuration() to swap to a USB block device at the 
> same time that an I/O error occurs, requiring a reset.  I think we can 
> live with that.

Hm. Chances are, if a reset is needed, the device would not cleanly
switch configurations, too.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux