On Mon, Dec 09, 2024 at 07:10:14PM +0800, Xu Yang wrote:
> On Mon, Dec 09, 2024 at 11:46:59AM +0100, Greg KH wrote:
> > On Mon, Dec 09, 2024 at 06:41:49PM +0800, Xu Yang wrote:
> > > The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or
> > > software node property. This will set skip_phy_initialization if software
> > > node also has XHCI_SKIP_PHY_INIT property.
> > >
> > > Fixes: a6cd2b3fa894 ("usb: host: xhci-plat: Parse xhci-missing_cas_quirk and apply quirk")
> > > Cc: stable@xxxxxxxxxxxxxxx
> > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> > >
> > > ---
> > > Changes in v2:
> > > - fix indentation
> > > - add fix tag and stable list
> > > ---
> > > drivers/usb/host/xhci-plat.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > > index e6c9006bd568..77853b86794a 100644
> > > --- a/drivers/usb/host/xhci-plat.c
> > > +++ b/drivers/usb/host/xhci-plat.c
> > > @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
> > >
> > > hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
> > >
> > > - if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
> > > + if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) ||
> > > + (xhci->quirks & XHCI_SKIP_PHY_INIT))
> >
> > Doesn't checkpatch.pl complain about this? This is still not correct,
> > please follow the proper indentation rules here. If you have questions
> > about this, please ask your coworkers who understand the style
> > requirements for Linux.
>
> Sorry for wasting your time. It's a mistake. I made the change but it's not included finally.
> BTW, checkpatch.pl doesn't complain the format. Not sure why.
try --strict option.
Frank
>
> Thanks,
> Xu Yang
>
> >
> > thanks,
> >
> > greg k-h
