Re: [PATCH] usb:REduce scope of BKL in usbdev_open()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 12 Jan 2010, Oliver Neukum wrote:

> Am Dienstag, 12. Januar 2010 16:17:10 schrieb Alan Stern:
> > Can't we simply remove the BKL from devio.c entirely?
> 
> Sure, it just means auditing all drivers. Do you think it's worth it
> considering that open() is a rare operation? I am not sure.

Why does anything need to be audited?  Does the BKL protect devio.c
from anything else (or vice versa)?  Or put it another way: What might
go wrong if the BKL is removed?

The only thing I can see that looks at all suspicious is in
usbdev_lseek(), and that just acts to protect against concurrent
modifications of file->f_pos.  Everything else is already protected by
usb_lock_device().

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux