On 11/24/24 00:54, Foster Snowhill wrote:
> Originally, the total NCM header size was computed as the sum of two
> vaguely labelled constants. While accurate, it's not particularly clear
> where they're coming from.
>
> Use sizes of existing NCM structs where available. Define the total
> NDP16 size based on the maximum amount of DPEs that can fit into the
> iOS-specific fixed-size header.
>
> Fixes: a2d274c62e44 ("usbnet: ipheth: add CDC NCM support")
> Signed-off-by: Foster Snowhill <forst@xxxxxx>
This change is not addressing any real issue, it just makes the
following ones simpler, right?
If so, I think it's better to drop the fixes tag here and add the above
reasoning.
> ---
> Each individual patch in the v3 series tested with iPhone 15 Pro Max,
> iOS 18.1.1: compiled cleanly, ran iperf3 between phone and computer,
> observed no errors in either kernel log or interface statistics.
This should go in the cover letter (currently missing, please add it in
the next iteration).
Thanks,
Paolo
