On 19.11.2024 6:13 PM, Rob Herring wrote: > On Sat, Nov 16, 2024 at 12:17:52PM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> >> >> X1 has multiple DWC3 hosts, including one that's USB2, which naturally >> means it doesn't have a SuperSpeed interrupt. Make it optional to fix >> warnings such as: >> >> usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short > > That's a good start, but what about all the other warnings for usb > interrupts?: > > 13 usb@f92f8800: 'interrupt-names' is a required property > 11 usb@76f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short > 11 usb@6af8800: interrupts: [[0, 347, 4], [0, 243, 4]] is too short > 11 usb@6af8800: interrupt-names:1: 'qusb2_phy' was expected > 11 usb@6af8800: interrupt-names:0: 'pwr_event' was expected > 11 usb@6af8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq'] is too short > 9 usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short > 7 usb@c2f8800: interrupt-names: ['pwr_event', 'qusb2_phy', 'hs_phy_irq'] is too short > 5 usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short > 5 usb@8af8800: interrupt-names: ['pwr_event'] is too short > 4 usb@8af8800: interrupts: [[0, 62, 4]] is too short > 4 usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short I'll address most of those shortly. Need to dig up a couple old devices to make sure my findings reflect reality ;) Konrad