Hi Takashi, On 11/20/2024 4:15 AM, Takashi Iwai wrote: > On Wed, 06 Nov 2024 20:34:09 +0100, > Wesley Cheng wrote: >> +config SND_USB_AUDIO_QMI >> + tristate "Qualcomm Audio Offload driver" >> + depends on QCOM_QMI_HELPERS && SND_USB_AUDIO && USB_XHCI_SEC_INTR && SND_SOC_USB >> + select SND_PCM > This select is superfluous as it already depends on > CONFIG_SND_USB_AUDIO that does select it. ACK. >> diff --git a/sound/usb/qcom/Makefile b/sound/usb/qcom/Makefile >> new file mode 100644 >> index 000000000000..a81c9b28d484 >> --- /dev/null >> +++ b/sound/usb/qcom/Makefile >> @@ -0,0 +1,2 @@ >> +snd-usb-audio-qmi-objs := usb_audio_qmi_v01.o qc_audio_offload.o > Use snd-usb-audio-qmi-y instead of *-objs. > Will change this. Thanks Wesley Cheng