Re: [PATCH v3] usb: dwc3: remove unused sg struct member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks, Thinh and Greg, for the feedback!

On Tue, Nov 19, 2024 at 10:19:09PM +0000, Thinh Nguyen wrote:
> > Previously, this patch addressed a documentation warning caused by the
> 
> Remove this paragraph. This context only makes sense in this thread
> where the previous patch version is visible.
> 

I’ll update the commit message and remove the unnecessary paragraph as suggested.

> > Reported-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> 
> I'm not the one who should be attributed to by the Reported-by tag.
> 
> I think Greg was alluding to this report by Stephen Rothwell:
> https://lore.kernel.org/all/20241118194006.77c7b126@xxxxxxxxxxxxxxxx/
> 
> It wasn't Cc to the linux-usb list, so I'm not sure if you've seen it.
> If your change was base on the report above, then you can update the
> Reported-by tag accordingly.
> 

Regarding the report by Stephen Rothwell, I wasn’t aware of it before. I found the warning independently while trying to compile the Documentation subsystem, looking for bugs to address.

That said, now that I’m aware of Stephen’s thread, I wouldn’t mind updating the commit message to include a reference to it if you think it would help link the two discussions. Let me know your thoughts on this.

Thanks again for the clarification and the reviews!

Best,

Felipe




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux