I'm no longer able to replicate the issue, so I'm guessing some subsequent fixes solved it. I thought I tested them all but maybe I missed one. Thank you. On Wed, Nov 13, 2024 at 8:35 PM Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx> wrote: > > On Thu, Nov 07, 2024, Chris Morgan wrote: > > On Thu, Oct 31, 2024 at 01:33:54AM +0000, Thinh Nguyen wrote: > > > On Wed, Oct 30, 2024, Chris Morgan wrote: > > > > On Wed, Oct 30, 2024 at 03:10:34PM +0200, Roger Quadros wrote: > > > > > Hi Chris, > > > > > > > > > > On 30/10/2024 00:49, Thinh Nguyen wrote: > > > > > > Hi, > > > > > > > > > > > > On Tue, Oct 29, 2024, Chris Morgan wrote: > > > > > >> Sorry, to be specific it was the fix that causes the issues I'm now > > > > > >> observing. When I explicitly revert commit > > > > > >> 705e3ce37bccdf2ed6f848356ff355f480d51a91 things start working again > > > > > >> for me. With that commit in place, however, suspend fails for me. > > > > > > > > > > > > Ok, Roger's patch is causing issue on your platform and the $subject > > > > > > patch? Can you provide more details on your test sequence? > > > > > > > > > > > > * What does "no longer able to suspend" mean exactly (what error?) > > > > > > * What mode is your usb controller? > > > > > > * Is there any device connected while going into suspend? > > > > > > * Can you provide dwc3 regdump? > > > > > > > > > > Commit 705e3ce37bccdf2ed6f848356ff355f480d51a91 will enable > > > > > DWC3_GUSB2PHYCFG_SUSPHY in DWC3_GUSB2PHYCFG(i) > > > > > and DWC3_GUSB3PIPECTL_SUSPHY in DWC3_GUSB3PIPECTL(i) during > > > > > system suspend path, unless snps,dis_u2_susphy_quirk or > > > > > snps,dis_u3_susphy_quirk is set. > > > > > > > > > > I see rK356x.dtsi has snps,dis_u2_susphy_quirk; > > > > > Does adding snps,dis_u3_susphy_quirk resolve the issue? > > > > > > > > I'm afraid it does not fix the issue. Specifically when I do > > > > "systemctl suspend" the device begins to suspend but freezes with the > > > > kernel log output via serial console listed previously. Note I have > > > > console enabled in suspend. Additionally button input no longer > > > > works at this point. > > > > > > > > Specifically, I'm testing this with the Anbernic RG353P device based on > > > > the Rockchip RK3566 SoC, in case you're curious. > > > > > > > > I'm not able to get you a register dump post suspend attempt as the > > > > system completely freezes, however I can get you a dump prior to > > > > suspend if that will help? > > > > > > Yes, any data is useful. > > > > > > > > > > > Thank you, > > > > Chris > > > > > > Can you help answer the other bullet questions I have previously. > > > > > > Thanks, > > > Thinh > > > > I have 2 ports, here is a dump of each: > > > > usb@fcc00000: > > > > fd000000: > > Thanks for the dumps! They're helpful. Looks like the fcc00000 is device > mode and operating in usb2 speed only, and the fd000000 is host. > > Can you help narrow down the problems by checking these: > > When you set the snps,dis_u3_susphy_quirk, did you set it to both > controllers? > > Which controller suspend causes the problem? The host or the device or > both? you can check by unbind the driver for each 1 at a time to prevent > suspend. e.g.: > # echo usb@fcc00000 > /sys/bus/platform/drivers/dwc3/unbind > # echo usb@fd000000 > /sys/bus/platform/drivers/dwc3/unbind > > Thanks, > Thinh
