While working on the wakeup functionality of a RTC driver, I noticed that we have a few occasions where 'pm_wakeup.h' gets included directly despite the comment that it shouldn't be done. It doesn't build-break because these files also include 'device.h' either directly or via some indirection, mostly 'platform_device.h'. Still, respect the requirement that 'pm_wakeup.h' shall only be included in 'device.h' and not directly. Based on 6.12-rc7. Build-bot is happy and there are no dependencies. I suggest that each patch goes in via the relevant subsystem tree. Thanks and happy hacking, Wolfram Wolfram Sang (15): x86/platform/olpc-xo1-sci: don't include 'pm_wakeup.h' directly drivers core: don't include 'pm_wakeup.h' directly HID: google: don't include 'pm_wakeup.h' directly coresight: etm4x: don't include 'pm_wakeup.h' directly Input: spear-keyboard - don't include 'pm_wakeup.h' directly Input: sun4i-lradc-keys - don't include 'pm_wakeup.h' directly media: mceusb: don't include 'pm_wakeup.h' directly mmc: core: don't include 'pm_wakeup.h' directly net: phy: broadcom: don't include 'pm_wakeup.h' directly net: wwan: t7xx: don't include 'pm_wakeup.h' directly PCI: don't include 'pm_wakeup.h' directly platform/x86: quickstart: don't include 'pm_wakeup.h' directly rtc: brcmstb-waketimer: don't include 'pm_wakeup.h' directly usb: typec: tcpci_mt6370: don't include 'pm_wakeup.h' directly PM / Sleep: don't include 'pm_wakeup.h' directly arch/x86/platform/olpc/olpc-xo1-sci.c | 1 - drivers/base/power/sysfs.c | 1 - drivers/hid/hid-google-hammer.c | 1 - drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 - drivers/input/keyboard/spear-keyboard.c | 1 - drivers/input/keyboard/sun4i-lradc-keys.c | 1 - drivers/media/rc/mceusb.c | 1 - drivers/mmc/core/core.c | 1 - drivers/mmc/core/host.c | 1 - drivers/net/phy/broadcom.c | 2 +- drivers/net/wwan/t7xx/t7xx_pci.c | 1 - drivers/pci/pci.c | 1 - drivers/platform/x86/quickstart.c | 1 - drivers/rtc/rtc-brcmstb-waketimer.c | 1 - drivers/usb/typec/tcpm/tcpci_mt6370.c | 1 - kernel/power/autosleep.c | 1 - 16 files changed, 1 insertion(+), 16 deletions(-) -- 2.39.2