On Mon, 11 Jan 2010, Pete Zaitcev wrote:
> Hello:
>
> I noticed this piece of code by accident:
>
> static void ftdi_determine_type(struct usb_serial_port *port)
> {
> ......
> /* Determine interface code. */
> inter = serial->interface->altsetting->desc.bInterfaceNumber;
> if (inter == 0) {
> priv->interface = INTERFACE_A;
>
> Is this supposed to be altsetting (in the instance, it's an equivalent
> of altsetting[0].desc) or cur_altsetting?
>
> The driver had a lot of mileage on it as-is, so even if this is a bug,
> it does not bother anyone apparently. So... Should we do anything here?
Although it is misleading and probably should be changed to
cur_altsetting, it's not really a bug. All altsettings in an interface
must have the same value for bInterfaceNumber.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
