On Wed, Nov 06, 2024 at 06:18:09PM +0800, Qiu-ji Chen wrote: > Our static checker found a bug where set_serial_info() uses a mutex, but > get_serial_info() does not. Fortunately, the impact of this is relatively > minor. It doesn't cause a crash or any other serious issues. However, if a > race condition occurs between set_serial_info() and get_serial_info(), > there is a chance that the data returned by get_serial_info() will be > meaningless. Perhaps "inconsistent" is a better word here. > Similar issues have been submitted or confirmed: > https://lore.kernel.org/all/20241002125845.785464707@xxxxxxxxxxxxxxxxxxx/ > https://lore.kernel.org/all/20241106095819.15194-1-chenqiuji666@xxxxxxxxx/ This should go under the --- line so that it's not included in the git logs. > Signed-off-by: Qiu-ji Chen <chenqiuji666@xxxxxxxxx> > Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()") And please use the expected patch prefix: USB: serial: ftdi_sio: ... Johan
