On Fri, Jan 08, 2010 at 08:07:51PM +0100, Stefan Brüns wrote:
> get rid of temporary iso frame descriptor (isopkt)
Why? I don't think you can rely on access_ok, copy_from_user() is
"safer" from what I remember.
> + if(uurb->type != USBDEVFS_URB_TYPE_ISO) {
> + as = alloc_async(0);
> + if (!as)
> + return -ENOMEM;
> + }
Why allocate one if we aren't going to use it?
Also, can you run your patch through 'scripts/checkpatch.pl' to catch
the minor formatting issues?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
