Dmitry Torokhov wrote: > On Friday 08 January 2010 09:13:29 am Greg KH wrote: >> On Fri, Jan 08, 2010 at 06:04:50PM +0100, Pavel Machek wrote: >> > On Fri 2010-01-08 09:50:33, Rick L. Vinyard, Jr. wrote: >> > > Pavel Machek wrote: >> > > > Hi! >> > > > >> > > >> > +static DEVICE_ATTR(name, 0666, g13_name_show, g13_name_store); >> > > >> >> > > >> What this attribute is for? >> > > > >> > > > Actually, all the new files this added need to be documented. >> > > >> > > Which is better? A hid-g13.txt file added to Documentation/ or >> comments >> > > in the driver itself? >> > >> > Documentation. Coordinate with sysfs maintainer (gregkh). >> >> All sysfs files need to be documented in Documentation/ABI/ Please add >> the documentation there for your new sysfs files. > > We need to have an agreement that all of them are needed first though. > > -- > Dmitry > True. I'm still working through your comments. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html