Thanks again, heikki. > -----邮件原件----- > 发件人: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > 发送时间: 2024年10月30日 21:20 > 收件人: Rex Nie <rex.nie@xxxxxxxxxxxxxxx> > 抄送: bryan.odonoghue@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > linux@xxxxxxxxxxxx; caleb.connolly@xxxxxxxxxx; > linux-arm-msm@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; Angus Chen <angus.chen@xxxxxxxxxxxxxxx>; > stable@xxxxxxxxxxxxxxx > 主题: Re: [PATCH v3] usb: typec: qcom-pmic: init value of hdr_len/txbuf_len > earlier > > External Mail: This email originated from OUTSIDE of the organization! > Do not click links, open attachments or provide ANY information unless you > recognize the sender and know the content is safe. > > > On Wed, Oct 30, 2024 at 06:32:57PM +0800, Rex Nie wrote: > > If the read of USB_PDPHY_RX_ACKNOWLEDGE_REG failed, then hdr_len and > > txbuf_len are uninitialized. This commit stops to print uninitialized > > value and misleading/false data. > > > > --- > > V2 -> V3: > > - add changelog, add Fixes tag, add Cc stable ml. Thanks heikki > > - Link to v2: > > https://lore.kernel.org/all/20241030022753.2045-1-rex.nie@jaguarmicro. > > com/ > > V1 -> V2: > > - keep printout when data didn't transmit, thanks Bjorn, bod, greg k-h > > - Links: > > https://lore.kernel.org/all/b177e736-e640-47ed-9f1e-ee65971dfc9c@linar > > o.org/ > > > > Cc: stable@xxxxxxxxxxxxxxx > > Fixes: a4422ff22142 (" usb: typec: qcom: Add Qualcomm PMIC Type-C > > driver") > > Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx> > > Sorry, but this is still broken. > > Those tags need to come before the "---". Otherwise they will not end-up into > the actual commit when this patch is applied. > > It should look something like this: > > usb: typec: qcom-pmic: init value of hdr_len/txbuf_len earlier > > If the read of USB_PDPHY_RX_ACKNOWLEDGE_REG failed, then > hdr_len and > txbuf_len are uninitialized. This commit stops to print uninitialized > value and misleading/false data. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: a4422ff22142 (" usb: typec: qcom: Add Qualcomm PMIC > Type-C driver") > Signed-off-by: Rex Nie <rex.nie@xxxxxxxxxxxxxxx> > --- > V2 -> V3: > - add changelog, add Fixes tag, add Cc stable ml. Thanks heikki > - Link to v2: > https://lore.kernel.org/all/20241030022753.2045-1-rex.nie@xxxxxxxxxxxxxx > m/ > V1 -> V2: > - keep printout when data didn't transmit, thanks Bjorn, bod, greg > k-h > - Links: > https://lore.kernel.org/all/b177e736-e640-47ed-9f1e-ee65971dfc9c@linaro. > org/ > > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 8 > ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec... > > thanks, > > -- > heikki
