On Mon, Oct 28, 2024 at 07:12:51PM +0800, Chia-Lin Kao (AceLan) wrote: > On Mon, Oct 28, 2024 at 12:51:21PM +0200, Mika Westerberg wrote: > > Normally there is no need to enumerate retimers on the other side of the > > cable. This is only needed in special cases where user wants to run > > receiver lane margining against the downstream facing port of a retimer. > > Furthermore this might confuse the userspace tools such as fwupd because > > it cannot read the information it expects from these retimers. > > > > Fix this by changing the retimer enumeration code to add only on-board > > retimers when CONFIG_USB4_DEBUGFS_MARGINING is not enabled. > > > > Reported-by: AceLan Kao <acelan.kao@xxxxxxxxxxxxx> > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219420 > > Cc: stable@xxxxxxxxxxxxxxx > > Fixes: ff6ab055e070 ("thunderbolt: Add receiver lane margining support for retimers") > > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > --- > > Hi AceLan, > > > > I changed the patch slightly. I wonder if you could try it again? > Yes, this revision also fixes the issue. > Thanks. > > Tested-by: AceLan Kao <acelan.kao@xxxxxxxxxxxxx> Thanks for testing! Applied to thunderbolt.git/fixes.
