Re: [RFC] gadget ethernet dma align fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Pandita, Vikram a écrit :
> Matthieu
> 
>> -----Original Message-----
>> From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of matthieu
>> castet
>> Sent: Wednesday, December 23, 2009 2:11 PM
>> To: linux-usb@xxxxxxxxxxxxxxx
>> Cc: Alan Stern
>> Subject: [RFC] gadget ethernet dma align fix
>>
>> Hi,
>>
>> I attach a patch that should allow to use gadget ethernet with driver
>> not supporting dma on unaligned address.
>>
>> This is untested on real hardware.
> 
> Gave a first round of test on real hardware.
> 
> 1) patch did not compile
> 	a) missing ;
> 	b) a typecast was needed like: ((unsigned long)skb->data & 3)
> 	c) WARN_ON() getting hit multiple times, thereby generating un-managable amount of logs: so disable WARN_ON()
That's not normal. We drop all these packets. That should explain why
"Ping from device side hangs" is not working.

What's the value of skb_headroom in this case.
May be the check should be
if ( (skb_headroom(skb) < ((unsigned long)skb->data & 3) ))



Matthieu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux