Hi Tony, kernel test robot noticed the following build warnings: [auto build test WARNING on johan-usb-serial/usb-next] [also build test WARNING on johan-usb-serial/usb-linus usb/usb-testing usb/usb-next usb/usb-linus tty/tty-testing tty/tty-next tty/tty-linus linus/master v6.12-rc4 next-20241024] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tony-Chung/usb-serial-mos7840-Fix-coding-style-warnings/20241023-171615 base: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git usb-next patch link: https://lore.kernel.org/r/20241023091414.18098-1-tony467913%40gmail.com patch subject: [PATCH] usb: serial: mos7840: Fix coding style warnings config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20241025/202410250141.AEkzzW60-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241025/202410250141.AEkzzW60-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202410250141.AEkzzW60-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/usb/serial/mos7840.c: In function 'mos7840_write': drivers/usb/serial/mos7840.c:923:39: warning: missing terminating " character 923 | dev_err_console(port, "%s - usb_submit_urb(write bulk) failed | ^ drivers/usb/serial/mos7840.c:924:43: warning: missing terminating " character 924 | with status = %d\n", __func__, status); | ^ drivers/usb/serial/mos7840.c:1832:23: error: unterminated argument list invoking macro "dev_err_console" 1832 | MODULE_LICENSE("GPL"); | ^ drivers/usb/serial/mos7840.c:923:17: error: 'dev_err_console' undeclared (first use in this function); did you mean 'dev_err_probe'? 923 | dev_err_console(port, "%s - usb_submit_urb(write bulk) failed | ^~~~~~~~~~~~~~~ | dev_err_probe drivers/usb/serial/mos7840.c:923:17: note: each undeclared identifier is reported only once for each function it appears in drivers/usb/serial/mos7840.c:923:32: error: expected ';' at end of input 923 | dev_err_console(port, "%s - usb_submit_urb(write bulk) failed | ^ | ; ...... drivers/usb/serial/mos7840.c:923:17: error: expected declaration or statement at end of input 923 | dev_err_console(port, "%s - usb_submit_urb(write bulk) failed | ^~~~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:923:17: error: expected declaration or statement at end of input drivers/usb/serial/mos7840.c:887:25: error: label 'exit' used but not defined 887 | goto exit; | ^~~~ drivers/usb/serial/mos7840.c:856:13: warning: variable 'bytes_sent' set but not used [-Wunused-but-set-variable] 856 | int bytes_sent = 0; | ^~~~~~~~~~ drivers/usb/serial/mos7840.c: At top level: drivers/usb/serial/mos7840.c:849:12: warning: 'mos7840_write' defined but not used [-Wunused-function] 849 | static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port, | ^~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:820:21: warning: 'mos7840_write_room' defined but not used [-Wunused-function] 820 | static unsigned int mos7840_write_room(struct tty_struct *tty) | ^~~~~~~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:795:12: warning: 'mos7840_break' defined but not used [-Wunused-function] 795 | static int mos7840_break(struct tty_struct *tty, int break_state) | ^~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:764:13: warning: 'mos7840_close' defined but not used [-Wunused-function] 764 | static void mos7840_close(struct usb_serial_port *port) | ^~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:737:21: warning: 'mos7840_chars_in_buffer' defined but not used [-Wunused-function] 737 | static unsigned int mos7840_chars_in_buffer(struct tty_struct *tty) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:516:12: warning: 'mos7840_open' defined but not used [-Wunused-function] 516 | static int mos7840_open(struct tty_struct *tty, struct usb_serial_port *port) | ^~~~~~~~~~~~ drivers/usb/serial/mos7840.c:410:13: warning: 'mos7840_led_flag_off' defined but not used [-Wunused-function] 410 | static void mos7840_led_flag_off(struct timer_list *t) | ^~~~~~~~~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:400:13: warning: 'mos7840_led_off' defined but not used [-Wunused-function] 400 | static void mos7840_led_off(struct timer_list *t) | ^~~~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:391:13: warning: 'mos7840_set_led_sync' defined but not used [-Wunused-function] 391 | static void mos7840_set_led_sync(struct usb_serial_port *port, __u16 reg, | ^~~~~~~~~~~~~~~~~~~~ drivers/usb/serial/mos7840.c:337:13: warning: 'mos7840_dump_serial_port' defined but not used [-Wunused-function] 337 | static void mos7840_dump_serial_port(struct usb_serial_port *port, | ^~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/usb/serial/mos7840.c:168:35: warning: 'id_table' defined but not used [-Wunused-const-variable=] 168 | static const struct usb_device_id id_table[] = { | ^~~~~~~~ vim +/id_table +168 drivers/usb/serial/mos7840.c 375cb533c00a237 Johan Hovold 2019-11-07 164 375cb533c00a237 Johan Hovold 2019-11-07 165 #define MCS_DEVICE(vid, pid, flags) \ 375cb533c00a237 Johan Hovold 2019-11-07 166 USB_DEVICE((vid), (pid)), .driver_info = (flags) 375cb533c00a237 Johan Hovold 2019-11-07 167 b9c87663eead64c Tony Zelenoff 2012-06-05 @168 static const struct usb_device_id id_table[] = { 375cb533c00a237 Johan Hovold 2019-11-07 169 { MCS_DEVICE(0x0557, 0x2011, MCS_PORTS(4)) }, /* ATEN UC2324 */ 375cb533c00a237 Johan Hovold 2019-11-07 170 { MCS_DEVICE(0x0557, 0x7820, MCS_PORTS(2)) }, /* ATEN UC2322 */ 375cb533c00a237 Johan Hovold 2019-11-07 171 { MCS_DEVICE(0x110a, 0x2210, MCS_PORTS(2)) }, /* Moxa UPort 2210 */ 375cb533c00a237 Johan Hovold 2019-11-07 172 { MCS_DEVICE(0x9710, 0x7810, MCS_PORTS(1) | MCS_LED) }, /* ASIX MCS7810 */ 375cb533c00a237 Johan Hovold 2019-11-07 173 { MCS_DEVICE(0x9710, 0x7820, MCS_PORTS(2)) }, /* MosChip MCS7820 */ 375cb533c00a237 Johan Hovold 2019-11-07 174 { MCS_DEVICE(0x9710, 0x7840, MCS_PORTS(4)) }, /* MosChip MCS7840 */ 375cb533c00a237 Johan Hovold 2019-11-07 175 { MCS_DEVICE(0x9710, 0x7843, MCS_PORTS(3)) }, /* ASIX MCS7840 3 port */ acf509ae28301d7 Cliff Brake 2009-12-01 176 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USO9ML2_2) }, 870408c82910158 Dave Ludlow 2010-09-01 177 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USO9ML2_2P) }, acf509ae28301d7 Cliff Brake 2009-12-01 178 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USO9ML2_4) }, 870408c82910158 Dave Ludlow 2010-09-01 179 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USO9ML2_4P) }, acf509ae28301d7 Cliff Brake 2009-12-01 180 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_US9ML2_2) }, acf509ae28301d7 Cliff Brake 2009-12-01 181 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_US9ML2_4) }, acf509ae28301d7 Cliff Brake 2009-12-01 182 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USPTL4_2) }, acf509ae28301d7 Cliff Brake 2009-12-01 183 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USPTL4_4) }, 11e1abb453690a9 David Ludlow 2008-02-25 184 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_2) }, 870408c82910158 Dave Ludlow 2010-09-01 185 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_2P) }, acf509ae28301d7 Cliff Brake 2009-12-01 186 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_4) }, 870408c82910158 Dave Ludlow 2010-09-01 187 { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_4P) }, 3f5429746d91f21 Paul B Schroeder 2006-08-31 188 {} /* terminating entry */ 3f5429746d91f21 Paul B Schroeder 2006-08-31 189 }; 68e24113457e437 Greg Kroah-Hartman 2012-05-08 190 MODULE_DEVICE_TABLE(usb, id_table); 3f5429746d91f21 Paul B Schroeder 2006-08-31 191 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
