Hi Yanik, > + /* > + * some chips asert fault alert, even if it is masked. > + * The FAULT_STATUS is read and > + */ > + if (status & TCPC_ALERT_FAULT) > + regmap_read(tcpci->regmap, TCPC_FAULT_STATUS, &raw); > + regmap_write(tcpci->regmap, TCPC_FAULT_STATUS, raw); Would it make sense to register TCPC_ALERT_FAULT to the alert mask as well? If TCPC_ALERT_FAULT would be the only alert to trigger an IRQ, will tcpci_irq still run if it is masked? i.e., can this patch only read/clear the fault status because it piggybacks off of another alert? Best, RD
