> > > > +void typec_partner_set_usb_mode(struct typec_partner *partner, enum usb_mode mode) > > > > +{ > > > > + if (!partner || partner->usb_mode == mode) > > > > + return; > > > > + > > > > + partner->usb_capability |= BIT(mode - 1); > > > > + partner->usb_mode = mode; > > > > + sysfs_notify(&partner->dev.kobj, NULL, "usb_mode"); > > > > > > Who is listening for this and what are they going to do with the > > > information? > > > > I'll drop it, unless Abhishek, you guys would have use for it. Let me > > know. I'll send v4 next week. > > I think you are ok to remove this. We would care about this value when > registering the partner and when activating a specific USB mode. With > the latter, we can just depend on the synchronous nature of > usb_mode_store (i.e. we can check the result after writing to the > sysfs file). Okay. I'll drop it. thanks, -- heikki