RE: [PATCH v2 1/2] ARM : OMAP : Add empty functions in header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>It needs to be static inline:

[Maulik] Yes that's true. 

>>And you need to make sure that the actual body of the function in the
>>C file is encapsulated with #ifdef too, since the very point of having
>>it under a config option is to not include it if it's not selected
>>and needed.

[Maulik] The actual body of the function is defined in 
drivers/usb/otg/nop-usb-xceiv.c. This file is compiled only if
CONFIG_NOP_USB_XCEIV option is selected. 

Hence I think we won't need to explicitly protect it with a #ifdef.

I shall post a new version of the patch with the changes.

Regards,
Maulik



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux