Re: [PATCH v1 2/4] usb: typec: Add attribute file showing the USB Modes of the partner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Heikki,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.12-rc1 next-20241004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Heikki-Krogerus/usb-typec-Add-attribute-file-showing-the-USB-Modes-of-the-partner/20241004-230547
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20241004140440.1882311-3-heikki.krogerus%40linux.intel.com
patch subject: [PATCH v1 2/4] usb: typec: Add attribute file showing the USB Modes of the partner
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241005/202410051504.tccjB1Cp-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051504.tccjB1Cp-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410051504.tccjB1Cp-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/usb/typec/class.c:630: warning: Function parameter or struct member 'usb_mode' not described in 'typec_partner_set_usb_mode'
>> drivers/usb/typec/class.c:630: warning: Excess function parameter 'mode' description in 'typec_partner_set_usb_mode'


vim +630 drivers/usb/typec/class.c

   620	
   621	/**
   622	 * typec_partner_set_usb_mode - Assign active USB Mode for the partner
   623	 * @partner: USB Type-C partner
   624	 * @mode: USB Mode (USB2, USB3 or USB4)
   625	 *
   626	 * The port drivers can use this function to assign the active USB Mode to
   627	 * @partner. The USB Mode can change for example due to Data Reset.
   628	 */
   629	void typec_partner_set_usb_mode(struct typec_partner *partner, enum usb_mode usb_mode)
 > 630	{
   631		if (!partner || partner->usb_mode == usb_mode)
   632			return;
   633	
   634		partner->usb_capability |= BIT(usb_mode - 1);
   635		partner->usb_mode = usb_mode;
   636		sysfs_notify(&partner->dev.kobj, NULL, "usb_mode");
   637	}
   638	EXPORT_SYMBOL_GPL(typec_partner_set_usb_mode);
   639	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux