Fix checkpatch error "do not use assignment in if condition" Signed-off-by: Manuel Quintero F <sakunix@xxxxxxxxx> Signed-off-by: Manuel Quintero F <sakunix@xxxxxxxxx> --- drivers/usb/atm/speedtch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/atm/speedtch.c b/drivers/usb/atm/speedtch.c index 973548b5c15c..dfd362abf602 100644 --- a/drivers/usb/atm/speedtch.c +++ b/drivers/usb/atm/speedtch.c @@ -324,7 +324,9 @@ static int speedtch_upload_firmware(struct speedtch_instance_data *instance, because we're in our own kernel thread anyway. */ msleep_interruptible(1000); - if ((ret = usb_set_interface(usb_dev, INTERFACE_DATA, instance->params.altsetting)) < 0) { + ret = usb_set_interface(usb_dev, INTERFACE_DATA, instance->params.altsetting + + if (ret < 0) { usb_err(usbatm, "%s: setting interface to %d failed (%d)!\n", __func__, instance->params.altsetting, ret); goto out_free; } -- 2.45.2