On Mon, 4 Jan 2010 12:20:17 -0800 Sarah Sharp wrote:
> Randy Dunlap reported this error when compiling the xHCI driver:
That should be:
Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> linux-next-20100104/drivers/usb/host/xhci.h:1214:
> sorry, unimplemented: inlining failed in call to 'xhci_get_slot_state': function body not available
>
> The xhci_get_slot_state() function belongs in xhci-dbg.c, since it
> involves debugging internal xHCI structures. However, it is only used in
> xhci-hcd.c. Some toolchains may have issues since the inlined function
> body is not in the xhci.h header file. Remove the inline keyword to avoid
> this.
>
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> Cc: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> ---
>
>
> Randy, does this fix your problem?
yes, thnx.
Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Sarah
>
>
> drivers/usb/host/xhci-dbg.c | 2 +-
> drivers/usb/host/xhci.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
> index b2915ae..105fa8b 100644
> --- a/drivers/usb/host/xhci-dbg.c
> +++ b/drivers/usb/host/xhci-dbg.c
> @@ -406,7 +406,7 @@ static void dbg_rsvd64(struct xhci_hcd *xhci, u64 *ctx, dma_addr_t dma)
> }
> }
>
> -inline char *xhci_get_slot_state(struct xhci_hcd *xhci,
> +char *xhci_get_slot_state(struct xhci_hcd *xhci,
> struct xhci_container_ctx *ctx)
> {
> struct xhci_slot_ctx *slot_ctx = xhci_get_slot_ctx(xhci, ctx);
> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
> index 741ece4..e5eb09b 100644
> --- a/drivers/usb/host/xhci.h
> +++ b/drivers/usb/host/xhci.h
> @@ -1210,7 +1210,7 @@ void xhci_dbg_erst(struct xhci_hcd *xhci, struct xhci_erst *erst);
> void xhci_dbg_cmd_ptrs(struct xhci_hcd *xhci);
> void xhci_dbg_ring_ptrs(struct xhci_hcd *xhci, struct xhci_ring *ring);
> void xhci_dbg_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx, unsigned int last_ep);
> -inline char *xhci_get_slot_state(struct xhci_hcd *xhci,
> +char *xhci_get_slot_state(struct xhci_hcd *xhci,
> struct xhci_container_ctx *ctx);
>
> /* xHCI memory management */
> --
> 1.6.3.3
>
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
