On 2024-09-23 23:20:19 [+0300], Mikhail Arkhipov wrote: > The function r8a66597_free_request is already called in the err_add_udc > block, and freeing r8a66597->ep0_req twice may lead to a double free error. > > If the probe process fails and the r8a66597_probe function subsequently > goes through its error handling path. Since r8a66597_free_request is called > multiple times in different error handling sections, it leads to an attempt > to free the same memory twice. > > Remove the redundant call to r8a66597_free_request in the clean_up2 block. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 0f91349b89f3 ("usb: gadget: convert all users to the new udc infrastructure") > Signed-off-by: Mikhail Arkhipov <m.arhipov@xxxxxxx> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> Sebastian