On Wed, Sep 25, 2024 at 09:25:01AM GMT, Abhishek Pandit-Subedi wrote: > > Hi Heikki, Tzung-Bi et al, > > This patch series adds support for alternate mode entry for the > cros-ec-typec driver for Displayport and Thunderbolt. > > Thunderbolt support is added by adapting an RFC Heikki had posted > previously: > > https://lore.kernel.org/linux-usb/20191230152857.43917-1-heikki.krogerus@xxxxxxxxxxxxxxx/ > > A few comments on the series: > > * The cros-ec interface will not accept any VDOs/VDMs so we simply > ignore any configurations we are passed (i.e. DPConfigure). This means > the sysfs control of DP lanes won't work. > * ChromeOS has two modes of operation for alt-modes: entirely EC driven > or AP-driven from userspace (via the typec daemon). Thus, we never > expect the kernel alt-mode drivers to auto-enter modes. > > This was tested on kernel 6.6 with a ChromeOS Brya device and compile > tested against linux-usb (with allmodconfig). Please test on top of the linux-usb or linux-next. 6.6 is nine months old kernel. Also for v2 please consider CC'ing both lists for all patches. Otherwise it's hard to follow the changes. > > Thanks, > Abhishek > > > -- With best wishes Dmitry
