RE: A question about ohci_irq()

["Huang, FrankR" <FrankR.Huang@xxxxxxx>]

I only want to clear that status bit if it is set.
Yes, I know it will be not processed by the driver if this OHCI_INTR_SO
is set. I referred some code on the internet and clear that, no other
important meaning. 


Thanks,
Frank

-----Original Message-----
From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] 
Sent: Friday, January 01, 2010 10:44 AM
To: Huang, FrankR
Cc: USB list
Subject: RE: A question about ohci_irq()

On Thu, 31 Dec 2009, Huang, FrankR wrote:

> Alan
> 
> 	Based on your patch, I add two lines code to clear the
> OHCI_INTR_SO bit of the intrstatus register if the OHCI_INTR_SO is set
> by HC.
> 
> /drivers/usb/host/ohci-hcd.c
> 
> 	ints = ohci_readl(ohci, &regs->intrstatus);
> ++	if((ints & OHCI_INTR_SO) == OHCI_INTR_SO){
> ++		ohci_writel(ohci, OHCI_INTR_SO, &regs->intrstatus);

Why do you want to do that?  Since OHCI_INTR_SO isn't set in 
regs->intrenable, it doesn't matter whether OHCI_INTR_SO is set in 
regs->intrstatus.

Alan Stern



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html