- Separated null checks for port, serial and private data. Signed-off-by: amin-amani <didi1364@xxxxxxxxx> --- drivers/usb/serial/digi_acceleport.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c index d1dea3850576..d858358f94d8 100644 --- a/drivers/usb/serial/digi_acceleport.c +++ b/drivers/usb/serial/digi_acceleport.c @@ -1309,9 +1309,14 @@ static void digi_read_bulk_callback(struct urb *urb) __func__, status); return; } - if (port->serial == NULL || - (serial_priv = usb_get_serial_data(port->serial)) == NULL) { - dev_err(&port->dev, "%s: serial is bad or serial->private " + if (port->serial == NULL) { + dev_err(&port->dev, "%s: serial is bad," + " status=%d\n", __func__, status); + return; + } + serial_priv = usb_get_serial_data(port->serial); + if (serial_priv == NULL) { + dev_err(&port->dev, "%s:serial->private " "is NULL, status=%d\n", __func__, status); return; } -- 2.25.1